Repository navigation
Conversation
loaff123
marked this pull request as ready for review
October 2, 2026 09:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1538.
Exodus HEX20 places vertical midside nodes before top-face midside nodes. meshio uses VTK ordering, where those groups are reversed. Reading and writing previously changed only the index base, leaving eight positions incorrect.
Apply the self-inverse HEX20 permutation in both directions, without mutating input connectivity. Tests construct reader input directly with netCDF4 and inspect raw writer output directly with netCDF4, so inverse mistakes cannot cancel out. Cases cover multiple rows, mixed/repeated blocks, case-insensitive element names, int32/int64 connectivity, NumPy-dependent read dtype behavior, and read-only input arrays.
Validation rerun on Windows 11 / Python 3.11.9 / NumPy 2.4.6 / netCDF4 1.7.4:
python -m pytest -q tests/test_exodus.py: 29 passed.git diff --check: passed.Historical package evidence, not rerun in this session: Linux/Python 3.12 full suite with NumPy 1.26.4 reported 752 passed/10 skipped; the NumPy 2.5.3 full suite reported 727 passed/10 skipped plus 25 pre-existing DOLFIN/Gmsh/UGRID failures also reported on the base. The fresh Windows checks cover Exodus only; they do not establish a clean full suite.
HEX27 ordering and additional Exodus aliases remain outside scope. Existing PR #1550 changes the same Exodus reader/writer for time-series/field/cell data but its current diff does not implement this HEX20 ordering correction; later integration may require conflict resolution.
AI assistance was used to prepare and verify this patch. Submitted for maintainer review and upstream CI.