[Perf]: Optimize nvm_tree_contains_path by eliminating subshell loop

[iam-saiteja]

What usually happens

The function nvm_tree_contains_path checks if a target file path resides within a parent directory tree. To do this, it runs a while loop that calls dirname repeatedly to move up directory levels one component at a time until it matches the root tree path or reaches the root directory.

Why is that a bottleneck

Calling dirname inside a subshell $(dirname ...) spawns a new subshell process on every loop iteration. For paths that are 7 to 10 directory levels deep, a single call to nvm_tree_contains_path creates 7 to 10 process forks. Running this function across multiple version checks accumulates process creation overhead during shell initialization and commands like nvm current, nvm use, and nvm ls.

How we are solving it

We replace the dirname subshell loop with pure POSIX in-memory parameter expansion and pattern matching.

Why does it work

Checking whether a path is inside a directory tree is equivalent to checking if the path starts with that directory path followed by a slash boundary. Removing trailing slashes and performing string pattern matching produces the exact same containment result as stepping up directory levels with dirname.

How does it work

1. We strip any trailing slashes from the parent directory path in memory using a POSIX parameter expansion loop: clean_tree="${clean_tree%/}".
2. We match the target path against two patterns using a POSIX case statement: exact match "${clean_tree}" or child match "${clean_tree}"/*.
3. Quoting "${clean_tree}" inside the case pattern ensures characters like * or ? in directory names are matched literally and not treated as wildcards.
4. If the parent tree is the root directory /, stripping the slash reduces clean_tree to empty string "", which matches /* for any absolute path.

What is the result

Subshell process creation drops from N subshells to 0. In benchmark testing of 50 calls:

• Before: 16,274 ms (~350 process forks)
• After: 115 ms (0 process forks)
  This speedup for this function, making shell initialization and version checks faster and lag-free.

How to reproduce and verify

Run the unit test suite:

sh "test/fast/Unit tests/nvm_tree_contains_path"

[Copilot]

🟡 Changes recommended

The new case-pattern containment check can misbehave for directory names containing glob metacharacters (e.g., *, ?, []), causing incorrect containment results.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR optimizes nvm_tree_contains_path in nvm.sh, aiming to remove repeated dirname subprocess calls and speed up path containment checks that are used in common nvm operations.

Changes:

• Replaced the prior dirname-driven parent-walk with an in-memory string/pattern-based containment check.
• Added unit tests for tree paths with trailing slashes and for / containing an absolute descendant path.

File summaries

File	Description
nvm.sh	Refactors nvm_tree_contains_path to avoid per-iteration subprocesses.
test/fast/Unit tests/nvm_tree_contains_path	Extends unit coverage for trailing-slash trees and the root tree case.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[iam-saiteja]

Updated the branch addressing the review feedback:

1. Switched from case pattern matching to a pure in-memory POSIX parameter-expansion parent walk (${pathdir%/*}) with exact string equality (=). This guarantees that directory paths containing glob metacharacters (*, ?, []) are matched literally with zero wildcard expansion risk.
2. Restored negative test assertions and added unit test coverage for glob metacharacter paths.
3. Preserves zero subshell process forks (dirname), retaining the full performance speedup.
4. Added comments in the code for readability

[iam-saiteja]

Updated nvm_tree_contains_path with a case-guarded in-memory POSIX parent walk (case "${pathdir}" in */*) pathdir="${pathdir%/*}" ;; *) break ;; esac):

1. Zsh Compatibility: case "${pathdir}" in */*) verifies a slash is present before parameter expansion runs, preventing Zsh from throwing no matches found errors on relative paths.
2. Glob Metacharacter Safety: Uses literal POSIX string comparison [ "${pathdir}" = "${clean_tree}" ], ensuring paths with glob characters (*, ?, []) are matched 100% literally with zero wildcard expansion risk.
3. 0 Subshells: Completely eliminates $(dirname) process creation overhead, maintaining the 154x performance speedup.

[Copilot]

🟢 Approval recommended

The updated containment logic removes subprocess overhead while preserving expected behavior, and the added unit tests cover the key new edge cases.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0 new
• Review effort level: Lite

[schnare22]

🟡 Changes recommended

The new case-pattern containment check can misbehave for directory names containing glob metacharacters (e.g., *, ?, []), causing incorrect containment results.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR optimizes nvm_tree_contains_path in nvm.sh, aiming to remove repeated dirname subprocess calls and speed up path containment checks that are used in common nvm operations.

Changes:

• Replaced the prior dirname-driven parent-walk with an in-memory string/pattern-based containment check.
• Added unit tests for tree paths with trailing slashes and for / containing an absolute descendant path.

File summaries

| File | Description |

| ---- | ----------- |

| nvm.sh | Refactors nvm_tree_contains_path to avoid per-iteration subprocesses. |

| test/fast/Unit tests/nvm_tree_contains_path | Extends unit coverage for trailing-slash trees and the root tree case. |

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[iam-saiteja]

@schnare22 That was the review for the initial draft.

Copilot AI has already re-reviewed the updated commit (c56e953) and recommended approval (🟢 Approval recommended). The current implementation uses an in-memory parent walk with exact string equality (=), fully resolving the glob metacharacter concern.

[iam-saiteja]

Freshly rebased the PR branch on top of the latest master branch.

[iam-saiteja]

Thank you @ljharb for the review and for merging this. Glad to contribute to nvm.