Repository navigation
[Perf] remove subprocess forks from startup and nvm use paths - #3949
Merged
Merged
Conversation
…ore the full lookup
…m_ls` An alias of the same name still takes precedence, as it does in `nvm_ls`.
… -a` The file is read, not sourced. An `ID` with no OS of its own is only taken as Linux when the kernel's `ostype` says so; otherwise `uname -a` decides.
In zsh, `command printf` skips the builtin and forks `/usr/bin/printf`.
marble-sh
force-pushed
the
perf/fork-free-startup
branch
from
October 7, 2026 16:15
3d8980c to
55810db
Compare
… avoid `awk` where possible
marble-sh
force-pushed
the
perf/fork-free-startup
branch
3 times, most recently
from
October 7, 2026 21:37
20d4dc5 to
f354088
Compare
marble-sh
marked this pull request as ready for review
October 7, 2026 21:57
marble-sh
force-pushed
the
perf/fork-free-startup
branch
from
October 8, 2026 20:37
f354088 to
4034135
Compare
ljharb
force-pushed
the
perf/fork-free-startup
branch
from
October 8, 2026 22:18
4034135 to
d55a55c
Compare
ljharb
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the benchmark script written for this pull request and it's results can be found here: https://gist.github.com/marble-sh/6db64630838b0fc9c003b6e0b311373e . in general i've found these changes give a 100ms or more savings.
please let me know what i can do to improve the PR. i'm happy to split, narrow, or reorder as wanted.
addresses: #2334, #3410, #3416, #3425, #3508, #3811, #3930, #3935
if asked, i'd be happy to add the benchmark scripts to the pull request, or create a new pull request for them specifically.