Repository navigation
Conversation
Contributor
|
Amazing! |
Contributor
Author
Thanks, with a little help of Codex :-) But because we've been using Transcoder for many years, I have been using my own fork in which I made and tested these changes for a long time now, also on production, running without issues. Just so you know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Craft 5 counterpart to #79, semantically ported from its final Craft 4 implementation (
f18b5e8) onto the currentdevelop-v5branch rather than cherry-picking Craft 4 code.refreshVideoAsset()support with exact EncodeVideo path parity and targeted derivative cleanup.Compatibility decisions
useHashedNamesbehavior.bufsizefix.Verification
Final commit tested:
6cf15a8172650dc8c8fcb2850137872b947c54ce.composer validate --strict --no-plugins --no-check-version, PHP lint,composer phpstan, ECS,composer test-refresh,git diff --check, andnpm run docs:buildall pass. Documentation lint reports 0 errors and 78 existing style warnings.Manual follow-up
Environment-specific testing is still recommended for remote/S3 volumes, external queue drivers, and representative production-length media.
Related issues