Skip to content

feat(kruise): make rest-config QPS/Burst and image pullPolicy configurable - #215

Open
Uburro wants to merge 1 commit into
openkruise:masterfrom
Uburro:feat/kruise-manager-qps-burst-pullpolicy
Open

Uburro wants to merge 1 commit into
openkruise:masterfrom
Uburro:feat/kruise-manager-qps-burst-pullpolicy

Conversation

@Uburro

@Uburro Uburro commented Oct 5, 2026 •

Copy link
Copy Markdown

kruise-manager has --rest-config-qps/--rest-config-burst flags, but the chart doesn't expose them, so large clusters are stuck with the default client rate limits (30/50). The chart also hardcodes imagePullPolicy: Always and sets CPU limits that cause throttling.

  • add manager.restConfig.qps/burst (defaults 30/50, behaviour unchanged)
  • add manager.image.pullPolicy (default Always), used by manager and daemon
  • drop default CPU limits for manager and daemon
  • document new values in README

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to master. They are not published on branches.

@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrisliu1995 for approval by writing /assign @chrisliu1995 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…rable

kruise-manager has --rest-config-qps/--rest-config-burst flags, but the
chart doesn't expose them, so large clusters are stuck with the default
client rate limits (30/50). The chart also hardcodes
imagePullPolicy: Always and sets CPU limits that cause throttling.

- add manager.restConfig.qps/burst (defaults 30/50, behaviour unchanged)
- add manager.image.pullPolicy (default Always), used by manager and daemon
- drop default CPU limits for manager and daemon
- document new values in README

Signed-off-by: Uburro <grigorii.rochev@nebius.com>
@Uburro
Uburro force-pushed the feat/kruise-manager-qps-burst-pullpolicy branch from 1bcb62a to 9a755cf Compare November 11, 2026 15:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants