Skip to content

feat(agents): sync sandbox next CRDs and ship agentrole CRDs - #228

Open
furykerry wants to merge 1 commit into
openkruise:masterfrom
furykerry:sync/agents-config-2026-10-27
Open

furykerry wants to merge 1 commit into
openkruise:masterfrom
furykerry:sync/agents-config-2026-10-27

Conversation

@furykerry

Copy link
Copy Markdown
Member

Summary

Syncs the unreleased next/ CRDs of the sandbox controller and manager charts from openkruise/agents config/ at dff7c4bf9. No chart version, values.yaml, or release-pointer changes.

  • Refresh controller CRDs: checkpoints, sandboxclaims, sandboxtemplates.
  • Refresh manager CRDs: securityprofiles, globalsecurityprofiles.
  • Add manager CRDs agentroles and agentrolebindings (introduced by agents PR #1065), in the manager chart's wrapped form (helm.sh/resource-policy: keep, no leading ---), consumed by the templates/agentio/crds.yaml glob.

Drift checker

Initial CRD check (before apply): DRIFT on checkpoints, sandboxclaims, sandboxtemplates, securityprofiles, globalsecurityprofiles; agentroles/agentrolebindings unmapped. Final CRD check: exit 0, all 14 mapped CRDs OK.

Manifests check reports only accepted deviations (no template changes in this PR):

  • Chart-native selectorLabels values — control-plane, app.kubernetes.io/name, component render from {{ include "<chart>.name" . }} (e.g. agents-sandbox-manager vs source sandbox-manager). Left as-is: hardcoding source literals would change the immutable Deployment.spec.selector and break in-place upgrades from released chart versions.
  • Gateway envoy-config — listener_prometheus/admin_cluster are gated by gateway.envoy.prometheus.enabled (default false), and enable-auth by gateway.envoy.pluginConfig.enableAuth (default true). These shipped defaults are intentionally kept. Rendering the chart with the source overlay's values (prometheus.enabled=true, enableAuth=false) produces an envoy config semantically identical to config/sandbox-gateway.

Webhook (all 8 entries), RBAC rules, and identity resources (ServiceAccounts, bindings, automountServiceAccountToken) are at parity with the rendered source overlays.

CRD-upgrade impact

Additive schema changes plus two new CRDs. Existing custom resources remain valid; the manager CRDs carry helm.sh/resource-policy: keep so they are not removed on uninstall.

Test plan

  • helm template renders both charts cleanly (exit 0)
  • New CRDs render via the agentio glob with helm.sh/resource-policy: keep
  • CRD drift checker exits 0
  • Changed CRD files are yamllint-clean

Sync unreleased next/ CRDs from openkruise/agents config/ at
dff7c4bf9e469f39b6ea6ec99f84f2ced6aaa87a.

- Refresh controller CRDs: checkpoints, sandboxclaims, sandboxtemplates.
- Refresh manager CRDs: securityprofiles, globalsecurityprofiles.
- Add manager CRDs agentroles and agentrolebindings (wrapped chart form,
  helm.sh/resource-policy: keep), introduced by agents PR #1065.

CRD checker exits 0 (all 14 mapped CRDs OK). No chart version, values,
or release pointer changes. CRD upgrades are additive schema changes;
existing CRs remain valid.

Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
@kruise-bot
kruise-bot requested review from FillZpp and zmberg October 27, 2026 06:08
@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from furykerry by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants