Repository navigation
Conversation
Sync unreleased next/ CRDs from openkruise/agents config/ at dff7c4bf9e469f39b6ea6ec99f84f2ced6aaa87a. - Refresh controller CRDs: checkpoints, sandboxclaims, sandboxtemplates. - Refresh manager CRDs: securityprofiles, globalsecurityprofiles. - Add manager CRDs agentroles and agentrolebindings (wrapped chart form, helm.sh/resource-policy: keep), introduced by agents PR #1065. CRD checker exits 0 (all 14 mapped CRDs OK). No chart version, values, or release pointer changes. CRD upgrades are additive schema changes; existing CRs remain valid. Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the unreleased
next/CRDs of the sandbox controller and manager charts fromopenkruise/agentsconfig/atdff7c4bf9. No chart version,values.yaml, or release-pointer changes.checkpoints,sandboxclaims,sandboxtemplates.securityprofiles,globalsecurityprofiles.agentrolesandagentrolebindings(introduced by agents PR #1065), in the manager chart's wrapped form (helm.sh/resource-policy: keep, no leading---), consumed by thetemplates/agentio/crds.yamlglob.Drift checker
Initial CRD check (before apply):
DRIFTon checkpoints, sandboxclaims, sandboxtemplates, securityprofiles, globalsecurityprofiles;agentroles/agentrolebindingsunmapped. Final CRD check: exit 0, all 14 mapped CRDsOK.Manifests check reports only accepted deviations (no template changes in this PR):
selectorLabelsvalues —control-plane,app.kubernetes.io/name,componentrender from{{ include "<chart>.name" . }}(e.g.agents-sandbox-managervs sourcesandbox-manager). Left as-is: hardcoding source literals would change the immutableDeployment.spec.selectorand break in-place upgrades from released chart versions.envoy-config—listener_prometheus/admin_clusterare gated bygateway.envoy.prometheus.enabled(defaultfalse), andenable-authbygateway.envoy.pluginConfig.enableAuth(defaulttrue). These shipped defaults are intentionally kept. Rendering the chart with the source overlay's values (prometheus.enabled=true,enableAuth=false) produces an envoy config semantically identical toconfig/sandbox-gateway.Webhook (all 8 entries), RBAC rules, and identity resources (ServiceAccounts, bindings,
automountServiceAccountToken) are at parity with the rendered source overlays.CRD-upgrade impact
Additive schema changes plus two new CRDs. Existing custom resources remain valid; the manager CRDs carry
helm.sh/resource-policy: keepso they are not removed on uninstall.Test plan
helm templaterenders both charts cleanly (exit 0)helm.sh/resource-policy: keep