Repository navigation
Conversation
The daemonsets and sidecarsets CRDs in the next chart still carried the controller-gen placeholders (webhook-service/system) in their conversion webhook clientConfig, and statefulsets hardcoded kruise-system. kruise-manager rewrites the live CRDs at startup, so conversion works, but GitOps tools that self-heal keep restoring the placeholders and the CRDs never settle. Render kruise-webhook-service in .Values.installation.namespace for all three, matching the webhook configurations. Fixes openkruise#192 Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @lbarrosby! It looks like this is your first PR to openkruise/charts 🎉 |
Author
|
Friendly ping. If this isn't something you want in the project, feel free to say so and I'll close it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192
The
daemonsetsandsidecarsetsCRDs inversions/kruise/nextstill had the controller-gen placeholders inspec.conversion.webhook.clientConfig.service(webhook-service/system), andstatefulsetshardcodedkruise-system. kruise-manager patches the live CRDs at startup so conversion itself works, but with a self-healing GitOps setup the tool keeps putting the placeholders back and the two CRDs stay OutOfSync.All three now render
kruise-webhook-servicein{{ .Values.installation.namespace }}, the same values the webhook configurations and the Service inmanager.yamluse. Onlynextis touched, per the contributing guide.Checked with
helm lintandhelm template(default values and--set installation.namespace=openkruise): everyclientConfig.servicein the output now points atkruise-webhook-servicein the installation namespace, where before the two CRDs renderedwebhook-service/system.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.