Repository navigation
refactor: Bump brace-expansion from 5.0.9 to 5.0.12 and brace-expansion from 1.1.18 to 1.1.21 - #299
Conversation
…on from 1.1.18 to 1.1.21
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 12 minutes. View limit details
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 159 159
=========================================
Hits 159 159 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Closes #298
Security update for a transitive development dependency (lock file only).
brace-expansionis not inpackage.json; both copies are pulled in byminimatch. The upgrade resolves the medium-severity advisory GHSA-q2hr-2g5m-vwhr (CVE-2026-102277), a quadratic-time CPU denial of service in the{a},b}rewrite, which affectsbrace-expansion< 1.1.21and>= 4.0.0, < 5.0.12.node_modules/brace-expansionminimatch10.2.4 (^5.0.2), used by ESLint, Jasmine and nyc (viaglobandtest-exclude)node_modules/glob/node_modules/brace-expansionminimatch3.1.5 (^1.1.7), used byglob7.2.3 (via@babel/cliandmadge)The lock file was regenerated with
npm update brace-expansion --ignore-scripts. Both target versions are the latest releases of their lines.npm ls brace-expansion --omit=devis empty, so the package is development-only.The upgrade also includes the fixes for these advisories, whose alerts were auto-dismissed for the development scope:
The copy of
brace-expansion5.0.9 that is bundled inside thenpmpackage (node_modules/npm/node_modules/brace-expansion, pulled in by@semantic-release/npm) ships with npm's published package and is not changed by this PR. It is updated together withnpmitself (npm 11.21.1 bundles 5.0.12), so GitHub may keep the alert for the 5.x line open until then.Changes
push.apply, so long inputs can no longer exhaust the call stack.maxDepthoption that bounds the brace nesting depth (default 1,000); deeper groups are returned literally.maxRewritesoption that bounds the number of{a},b}rescans (default 1,000).The runtime dependencies (
balanced-matchandconcat-mapon 1.x,balanced-matchon 5.x) and the declared Node.js engines are unchanged. The remaining 5.x commits are formatting, CI,SECURITY.mdand development dependency updates in the brace-expansion repository.Breaking Changes
None
Code Changes Required
None — the upgrade is a drop-in replacement.
minimatch3.1.5 callsexpand(pattern)andminimatch10.2.4 callsexpand(pattern, { max: options.braceExpandMax }). Both signatures and themaxbehavior are unchanged, and the new limits only apply to pathological input far beyond the glob patterns used by ESLint, Jasmine, nyc, Babel and madge in this repository.