Skip to content

Remove legacy Android activities (pre-WebView UI) - #229

Merged
patriciojofre merged 6 commits into
masterfrom
chore/cleaning-legacy-vars
Jun 3, 2026
Merged

patriciojofre merged 6 commits into
masterfrom
chore/cleaning-legacy-vars

Conversation

@patriciojofre

@patriciojofre patriciojofre commented Jun 2, 2026 •

Copy link
Copy Markdown
Member

Cleans up the Activities layer by removing three clusters of dead code left over from before the app's UI was migrated to React WebViews.

What was removed

Cluster 1 — Legacy welcome flow

  • WelcomeActivity and DeviceReadyActivity: the original app entry point, superseded by LoginActivity. Neither was
    reachable in the current flow.

Cluster 2 — Native password flow (pre-Android N)

  • CheckPasswordActivity, PasswordActivity: native password screen replaced by CheckPasswordHtmlActivity.
  • PreyConfigurationActivity: extended the deprecated PreferenceActivity, unreachable in any active flow.
  • ChangePinPreferences: a dialog preference that only lived inside PreyConfigurationActivity.
  • Simplified LoginActivity.showLogin() — removed the dead SDK < N branch that routed to the native activities.
  • Simplified PermissionInformationActivity — removed the dead SDK < M branch.
  • Removed the preyConfigurationActivityResume flag from PreyStatus (only set and read by the removed classes).

Cluster 3 — Legacy Fingerprint API

  • FingerprintAuthenticationDialogFragment and FingerprintHelper: used the deprecated FingerprintManager API (superseded
    since Android 9). No active callers remained.

Layouts and resources deleted

device_ready.xml, password2.xml, fingerprint_dialog_container.xml, fingerprint_dialog_backup.xml,
fingerprint_dialog_content.xml, preferences_5.xml

patriciojofre and others added 5 commits June 2, 2026 13:43
… flow)

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…urationActivity)

Delete CheckPasswordActivity, PasswordActivity, PreyConfigurationActivity, and
ChangePinPreferences; simplify LoginActivity.showLogin() and
PermissionInformationActivity to always use CheckPasswordHtmlActivity; clean
PreyStatus of preyConfigurationActivityResume fields; fix
FingerprintAuthenticationDialogFragment to route to PanelWebActivity.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@patriciojofre patriciojofre changed the title Chore/cleaning legacy vars Remove legacy Android activities (pre-WebView UI) Jun 2, 2026
@patriciojofre
patriciojofre merged commit 6532f3a into master Jun 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant