Repository navigation
Measure the change of H as a frequency mismatch in step control - #93
Merged
DavidMStraub merged 1 commit intoNov 13, 2026
Merged
Conversation
The dispersion term of the step-size controller now divides the change of H by |ω ∂H/∂ω| at fixed wave vector, i.e. it controls the relative frequency mismatch δω/ω instead of |ΔH|/(2|N|). The measure does not depend on how H is normalized and equals the change of |N| in vacuum, as before. Taken from proximafusion#91 by @alpxp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispersion term of the step-size controller now measures the change of H over a step as the relative frequency mismatch δω/ω = |ΔH| / |ω ∂H/∂ω| at fixed wave vector, instead of |ΔH| / (2|N|). This does not depend on how H is normalized, and in vacuum it is the same as before (the change of |N|). The test compares ω ∂H/∂ω against a finite difference at fixed k.
This is taken from #91 by @alpxp, without the other changes in that PR.
Validation against Travis 13.3.1 (1000 samples each): compared with main on the same samples, Raytrax τ is unchanged in the median (max 0.9 %, O2) and the deposition location moves by at most 0.004 in ρ. Failure counts are the same. The trajectory statistics are unchanged. Wall time per ray is unchanged. The gradient of the deposition centroid with respect to the launch direction agrees with the one at rtol = 1e-9 to 1.6 % (main: 1.8 %).