Repository navigation
Conversation
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Contributor
|
diff-shades results comparing this PR (b7c13cc) to main (9a1f64e):
|
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Collaborator
Author
|
Note: it was mentioned on the issue how triple-quoted strings were always wrapped in parens too. I changed that to only wrap concatenated strings in parens (as with single-quoted strings), but kept those dicts containing single triple quoted strings broken. # Stable
{"a": """
"""}
# Preview (main)
{
"a": (
"""
"""
)
}
# Preview (this PR)
{
"a": """
"""
} |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4882
Instead of requiring no parens when there's no delimiters (as discussed on the issue), I choice to respect users' choice. While this adds a dependency on previous formatting, many of the examples in the test case were formatted worse without the parens.
Checklist - did you ...
--previewstyle, following the stability policy?CHANGES.mdif necessary?