Repository navigation
build(deps): update nuget packages and fix new analyzer findings - #1246
Open
glennawatson wants to merge 2 commits into
Open
glennawatson wants to merge 2 commits into
glennawatson wants to merge 2 commits into
Conversation
- Bump ReactiveUI.Primitives to 8.2, ReactiveUI to 24.3, TUnit, MinVer 8, PublicApiSharp 2.0.1 and the StyleSharp/PerformanceSharp/SecuritySharp analyzers to 5.1. - Drop the remaining third-party analyzer packages; sync .editorconfig with the new rule set. - Fix HttpService retries: Primitives 8 Retry(n) counts total runs, so the old "retries - 1" made one attempt too few. - Move internal-only helpers into internal extension classes so they add no public extension markers. - Use int latches with Interlocked for dispose/done flags, collection expressions with with(...), and AggressiveInlining on forwarding members. - Compare Size dimensions within a 0.001 pixel tolerance instead of exact float equality. - Add a match timeout to the ISO 8601 and BSON date regexes. - Regenerate the PublicAPI baselines and add missing exception docs and other analyzer cleanups across src, tests, samples and benchmarks.
glennawatson
force-pushed
the
glennawatson/update-nugets
branch
from
September 25, 2026 05:38
5b365b7 to
b8fcedc
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Updates every NuGet dependency to its latest version and fixes what the new versions and analyzers flagged.
.editorconfigis synced with the new rule set.Retry(n)in ReactiveUI.Primitives 8 counts total runs, matching System.Reactive, so the oldretries - 1compensation made one attempt too few.Sizeequality in Akavache.Drawing compares within a 0.001 pixel tolerance instead of exact float equality.Interlockedint latches, so two threads can no longer both pass the check. This coversSettingsStorageand the candidate-walking observable in Core.with(...),AggressiveInliningon forwarding members, missing<exception>docs and formatting.Why
Brings the repository up to date with the latest package releases. It replaces the individual dependency update PRs.
Breaking changes
None to the public API.
Akavache.Drawing.Sizenow treats sizes that differ by at most 0.001 pixels in each dimension as equal.How this was verified
The existing test suites cover the change, and the solution was also built on a Windows machine to cover the Windows desktop and Apple target frameworks.
Notes for the reviewer
Most of the diff is mechanical. Read the hand-written parts first.
HttpService.MakeWebRequest. It is the only behaviour change a consumer could notice apart fromSize.HttpService.cs,Size.cs,FirstMatchFromCandidatesObservable.cs(int latch),SettingsStorage.cs, and the new internal extension classes. Those areIsolatedStorageFileExtensions,DateTimeTypeExtensions,ImageBufferExtensions,BitmapBufferExtensions,SqliteCacheNameExtensions,EncryptedSqliteCacheNameExtensionsandV10CacheExtensions.SqliteCacheNameExtensions.csis excluded from the EncryptedSqlite3 projects, likeAkavacheBuilderExtensions.cs, because they glob the Sqlite3 sources.Equalsmethods, because it mirrorsSystem.HashCode.MethodImplattributes, collection expressions, doc additions andDebuggerDisplayattributes.Checklist