Repository navigation
feat: one redrob-board binary for the command line; drop the web build - #1
Merged
Merged
Conversation
- board-cli, board-drc, board-kicad-export and board-gerber-compare become subcommands of redrob-board (crates/app/src/cli): pipeline, tool, examples, drc, kicad-export, gerber-compare. Exit codes are unchanged. On Windows the command line attaches to the console it was started from. - the browser build is gone: apps/redrob-board-web, packaging/web, the wasm CI step, the release web job and the wasm-release profile. - board-fixtures and board-sim-fixtures stay as developer tools in their crates.
- ci.yml: one Linux job (fmt, clippy without test targets); the Windows leg and the push triggers are gone; clippy --all-targets and the tests run by hand (workflow_dispatch); a docs-only pull request skips the Rust job. - oracle.yml (KiCad / ngspice installs): by hand only. - packaging-lint and gitflow: no push triggers. No test code is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done
board-cli,board-drc,board-kicad-exportandboard-gerber-compareare nowredrob-board pipeline | tool | examples | drc | kicad-export | gerber-compare(crates/app/src/cli). Exit codes are unchanged; on Windows the command line attaches to the console it was started from.What's not done
board-fixturesandboard-sim-fixturesstay as developer tools in their crates.What to review
crates/app/src/cli/mod.rs(dispatch) andcrates/app/src/main.rs.Intentions
Agents and scripts reach every board tool through the shipped
redrob-boardbinary. Release gate on this branch: cargo fmt --check, cargo check / clippy --workspace --all-targets -D warnings and cargo test --workspace all exit 0.