Repository navigation
lib: cppc: fix fast channel region overlap detection - #126
Merged
Merged
Conversation
Fix the overlap check between performance request and feedback regions by comparing their relative offsets against the corresponding region sizes. Use subtraction instead of addition to avoid integer overflow when checking region boundaries. Signed-off-by: wuliwen <liwen.wu@spacemit.com>
Justin-Nickel-Wu
force-pushed
the
main
branch
from
October 30, 2026 07:34
1b640db to
25b180d
Compare
Collaborator
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the overlap check between performance request and feedback regions by comparing their relative offsets against the corresponding region sizes.
Problem
The previous implementation compared absolute offsets directly against region sizes, which could fail to detect overlapping regions when their offsets were non-zero.
Fix
Use relative offset comparisons to correctly detect overlapping regions, including regions with identical starting offsets.
Use subtraction instead of addition to avoid potential integer overflow.
Tests
makemake LIBRPMI_TEST=ymake check