Resolve user paths to an ID instead of an email address

profile and owned_gems interpolate the identifier into the path, and those endpoints take a handle or a user ID, never an email address. handle_of resolves the email parameter of the owner endpoints, so an owner with no handle produced /api/v1/profiles/someone@example.com.json.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: 2 people

lib/gems/api/gem_endpoints.rb

@@ -57,7 +57,7 @@ def autocomplete(query)
       #   Gems.owned_gems
       def owned_gems(user_handle = nil)
         path = if user_handle
-          "/api/v1/owners/#{handle_of(user_handle)}/gems.json"
+          "/api/v1/owners/#{slug_of(user_handle)}/gems.json"
         else
           "/api/v1/gems.json"
         end

lib/gems/api/profile_endpoints.rb

@@ -18,7 +18,7 @@ module ProfileEndpoints
       # @example
       #   Gems.profile "qrush"
       def profile(user)
-        Profile.new(JSON.parse(get("/api/v1/profiles/#{handle_of(user)}.json")))
+        Profile.new(JSON.parse(get("/api/v1/profiles/#{slug_of(user)}.json")))
       end
 
       # Returns basic information about your account

lib/gems/identifiers.rb

@@ -57,17 +57,28 @@ def full_name_of(gem, version, platform = nil)
       ::Gem::NameTuple.new(name_of(gem), number_of(version), platform || platform_of(version)).full_name
     end
 
-    # Resolve a user identifier from a handle, email address, ID, owner, or profile
+    # Resolve the email parameter from a handle, email address, owner, or profile
     # @api private
     # @param owner [String, Integer, Owner, Profile] a handle, email address, user ID, owner, or profile
-    # @return [String, Integer, nil] the handle or ID, or the email address when the user has no handle
+    # @return [String, Integer, nil] the handle, or the email address when the user has no handle
     def handle_of(owner)
       case owner
       when Owner, Profile then owner.handle || owner.email
       else owner
       end
     end
 
+    # Resolve a user identifier for a URL path from a handle, ID, owner, or profile
+    # @api private
+    # @param user [String, Integer, Owner, Profile] a handle, user ID, owner, or profile
+    # @return [String, Integer, nil] the handle, or the ID when the user has no handle
+    def slug_of(user)
+      case user
+      when Owner, Profile then user.handle || user.id
+      else user
+      end
+    end
+
     # Resolve a URL from a URL or a web hook
     # @api private
     # @param web_hook [String, WebHook] a URL or web hook

sig/gems.rbs

@@ -302,6 +302,7 @@ module Gems
     def platform_of: (version_identifier? version) -> String?
     def full_name_of: (gem_identifier gem, version_identifier version, ?String? platform) -> String
     def handle_of: (user_identifier owner) -> (String | Integer)?
+    def slug_of: (user_identifier user) -> (String | Integer)?
     def url_of: (web_hook_identifier web_hook) -> String?
     def key_of: (api_key_identifier? api_key) -> String?
     def timestamp_of: ((Time | String)? time) -> String?

spec/gems/api/gem_endpoints_spec.rb

@@ -88,6 +88,13 @@
       expect(a_get("/api/v1/owners/1/gems.json")).to have_been_made
     end
 
+    it "falls back to the ID of an owner without a handle" do
+      stub_get("/api/v1/owners/1/gems.json").to_return(body: fixture("gems.json"))
+      client.owned_gems(Gems::Owner.new("id" => 1, "email" => "sferik@gmail.com"))
+
+      expect(a_get("/api/v1/owners/1/gems.json")).to have_been_made
+    end
+
     context "without a user handle" do
       before { stub_get("/api/v1/gems.json").to_return(body: fixture("gems.json")) }
 

spec/gems/api/profile_endpoints_spec.rb

@@ -17,6 +17,13 @@
       expect(a_get("/api/v1/profiles/1.json")).to have_been_made
     end
 
+    it "falls back to the ID of an owner without a handle" do
+      stub_get("/api/v1/profiles/1.json").to_return(body: fixture("profile.json"))
+      client.profile(Gems::Owner.new("id" => 1, "email" => "nick@quaran.to"))
+
+      expect(a_get("/api/v1/profiles/1.json")).to have_been_made
+    end
+
     it "gets the correct resource" do
       client.profile("qrush")
 

spec/gems/identifiers_spec.rb

@@ -87,6 +87,24 @@
     end
   end
 
+  describe "#slug_of" do
+    it "returns a handle unchanged" do
+      expect(client.send(:slug_of, "sferik")).to eq("sferik")
+    end
+
+    it "returns the handle of an owner" do
+      expect(client.send(:slug_of, Gems::Owner.new("id" => 1, "handle" => "sferik"))).to eq("sferik")
+    end
+
+    it "falls back to the ID of an owner without a handle" do
+      expect(client.send(:slug_of, Gems::Owner.new("id" => 1, "email" => "sferik@gmail.com"))).to eq(1)
+    end
+
+    it "returns the handle of a profile" do
+      expect(client.send(:slug_of, Gems::Profile.new("id" => 1, "handle" => "sferik"))).to eq("sferik")
+    end
+  end
+
   describe "#url_of" do
     it "returns a URL unchanged" do
       expect(client.send(:url_of, "http://example.com")).to eq("http://example.com")