Repository navigation
chore: get __version__ dynamically instead of hardcoding the value - #19940
Merged
Merged
Conversation
dosubot
Bot
added
size:S
masci
changed the title
masci
changed the title
__version__ dynamically instead of hardcoding the value
masci
force-pushed
the
massi/__version__
branch
from
September 25, 2025 09:25
1f8e49f to
a47295e
Compare
logan-markewich
approved these changes
Sep 25, 2025
logan-markewich
left a comment
logan-markewich
left a comment
Collaborator
There was a problem hiding this comment.
Tested a bit locally, this seems safe imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Still unsure about the implications but @logan-markewich if you can double check this is safe, it will simplify the release process.