[aniketkrs]

Impact

Filtering a PGVectorStore on string metadata that merely looks numeric to Python, e.g. file_name="2024_123", crashes the query with DataError: invalid input syntax for type double precision instead of matching the document. Any metadata with underscores between digits (dates, IDs, filenames) makes metadata filtering unusable. This fixes #15962.

Cause

build_filter_clause probes float(value) to decide between the ::float and text SQL branches. Python's float() accepts underscores (float("2024_123") is 2024123.0), so the probe succeeds and emits (metadata->>'file_name')::float = 2024123.0, which Postgres rejects because the stored string is not a valid float literal. The except ValueError text fallback never fires.

Fix

Route string values containing _ to the existing text-comparison branch. Behavior is unchanged for every other input: genuine numeric strings ("3.14", "1e5") and real ints/floats still take the ::float path, and non-numeric strings still take the text path.

Fixes #15962.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

Closing as a duplicate: #22367 was opened earlier for the same issue (#15962).
We keep the oldest open PR per issue to avoid splitting review effort.

If this PR differs meaningfully, please comment and a maintainer can reopen it and add the not-duplicate label.