Repository navigation
fix(sagemaker): preserve generated text in streaming responses - #23626
Open
dsilvadeepal wants to merge 1 commit into
Open
dsilvadeepal wants to merge 1 commit into
dsilvadeepal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22221.
IOHandler.deserialize_streaming_outputuses character-set stripping to remove the JSON envelope. This drops valid leading letters and trailing brackets/quotes; for example,data engineeringbecomesengineering.Use exact prefix/suffix removal while retaining the existing fragment decoding behavior. Add regression coverage for full responses and fragments, including a mocked
SageMakerLLM.stream_completetest that verifies cumulative text and deltas. No dependency changes.Validation against main 619d746:
This does not add buffering for arbitrary byte splits inside JSON escapes, UTF-8 characters, or the envelope.
Related earlier unmerged attempts: #22222, #22226, #22260, #22440.
AI assistance: Codex helped diagnose, implement, and test this change. I reviewed the changes and tested them locally before submission.