Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SQLDatabase.insert_into_table("records", ...)raisesKeyErrorwhenSQLDatabasehas a configured schema: SQLAlchemy reflects the table under a key such asanalytics.records, but insertion looks uprecords.Resolve the schema-qualified metadata key first, while retaining exact-key lookup for callers already passing qualified names. This is a self-discovered bug; no existing issue is being claimed.
New Package?
Version Bump?
Not applicable to llama-index-core.
Type of Change
How Has This Been Tested?
Validation used Windows/Python 3.12 and in-memory SQLite; no external database or model API was used.
AI assistance
AI assisted with identifying the bug, implementing the metadata lookup, and writing regression tests. The checks above were run locally.