Repository navigation
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23679.
SimplePropertyGraphStore.upsert_relations()currently ignores updated properties when a relation's(source, label, target)already exists. For example, upserting aKNOWSrelation with confidence0.1and then0.9still returns0.1.Remove the early return in
LabelledPropertyGraph.add_triplet()so node/relation mappings receive the latest objects. The existing triplet set continues to prevent duplicates, including repeated identical upserts.add_node()already replaces nodes by identity.Validation
619d74664: 2 failed, 8 passed intests/graph_stores/test_simple_lpg.py; both new sync/async update cases return the stale confidence.PYTHONPATH=$PWD python -m pytest tests/graph_stores -q --tb=short: 10 passed.git diff --check: passed.--follow-imports=skipon both changed files: passed. Full repository typechecking/CI was not run locally.No dependency or core version change. Separate from shared-endpoint deletion (#23347) and relation-key collisions (#23437).
AI assistance was used for investigation, implementation and regression tests. Verified both baseline failures, reviewed the set/mapping update behavior, and ran the checks above. Submitted as draft for human review.