Repository navigation
fix(baiduvectordb): return L2 distances as higher-is-better similarities - #23737
Open
ninglinLiu wants to merge 1 commit into
Open
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaiduVectorDB.query()/aquery()passed Mochow's rawdistancestraight intoVectorStoreQueryResult.similarities. On the store's defaultL2metric that distance is lower-is-closer, so the best match got the lowest similarity and similarity cutoffs / score-based reranking ran backwards. COSINE and IP distances already grow with similarity (Baidu VDB docs).The store now remembers the table's configured metric and maps L2 distances to
1 / (1 + distance)(same conversion mem0 adopted for its Baidu provider in mem0ai/mem0#6435); COSINE/IP values pass through unchanged. Result order is unchanged.Fixes #23736
AI disclosure: I used an AI assistant to help locate this and draft the change. I reviewed the diff, checked the metric semantics against Baidu's docs, and ran the package tests plus
ruff check/ruff format --checklocally.