Repository navigation
fix: handle None backup separators in TokenTextSplitter - #23792
Open
Chaewon1000 wants to merge 1 commit into
Open
Chaewon1000 wants to merge 1 commit into
Chaewon1000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a Pydantic ValidationError that occurs when backup_separators=None is passed to TokenTextSplitter.
The constructor accepts Optional[List[str]], but the corresponding Pydantic field requires a list. This change normalizes None to an empty list before validation, preserving the existing behavior for valid separator lists.
Changes:
backup_separators=Noneto [] before callingsuper().__init__().Noneis handled correctly.Fixes #23790
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Test Results
ValidationErrorbefore the fix and passed afterward.test_token_splitter.pypassed.llama-index-coretest suite: 1,498 passed, 2 failed, 22 skipped, 6 xfailed.The two failing tests were:
tests/callbacks/test_llama_debug.py::test_get_event_statstests/schema/test_media_resource.py::test_hashThese failures appear unrelated to the changes in this PR, but have not been verified against an unmodified baseline.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods