Repository navigation
fix(#2705): optimize GraphQL metadata and isolate schema state - #2706
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freeform rebuilds the form-builder field catalog during GraphQL schema generation, slowing even
{ping}and queries unrelated to Freeform. Read registered field classes and PHP attributes directly, and return cached field types before rebuilding their definitions.The expanded GraphQL review also fixes four existing edge cases:
The export-selection unit tests use a scoped stand-in for Craft's generated CustomFieldBehavior, allowing clean dependency installs to run without bootstrapping a site. The original container is restored after each test.
Fixes #2705.
Validation:
QA used disposable forms without notifications. External CAPTCHA providers were disabled only on those forms; live provider verification, payments, and outbound notifications were not exercised. All QA forms, submissions, tokens, and schemas were removed afterward. The site's temporary Freeform/Calendar dependency links were restored.
Craft-core limitation: Craft 5.11.5.1 fails to load a prefixed root Query type even when all plugin GraphQL callbacks are removed. Prefix tests therefore used
prefixGqlRootTypes=false; the remaining root-prefix issue is outside this plugin.