Repository navigation
fix(ci): stop repointing staging webhook on releases, drop secret dump - #566
Merged
Merged
Conversation
The cr job has no environment, so on tag releases it runs with the repo-level (staging app) secrets while API_URL is the Production deployment. update-webhook-url.ts then pointed the staging app's webhook at the prod deployment, and every staging delivery failed with 500 until the next main push. Skip that step on tags. script/ci.ts wrote every NITRO_* secret plus GITHUB_TOKEN to packages/app/.dev.vars in the workspace, where every later step (including the playground publish) could read it. Nothing in the job reads that file for real values: update-webhook-url.ts gets them from its step env, and dotenv does not override existing env vars. Remove the step and the script, and drop the unused GITHUB_TOKEN from the webhook step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
commit: |
AmirSa12
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to INC-941 (staging app key leak).
Staging webhook pointed at prod after every release. The
crjob has noenvironment:, so onv*tags it runs with the repo-level secrets (the staging app, 859925) whileAPI_URLis the Production deployment.update-webhook-url.tsthen pointed the staging app's webhook at the prod deployment, so every staging delivery returned 500 until the nextmainpush. That was the state this morning (webhook onb61f21da.pkg-pr-new.pages.dev). The step now skips tag runs.Secrets written to disk.
script/ci.tswrote everyNITRO_*secret plusGITHUB_TOKENtopackages/app/.dev.vars, where every later step in the job could read it, including the playground publish. Nothing in the job reads real values from that file:update-webhook-url.tsgets them from its step env, and dotenv doesn't override existing env vars. Removed the step, the script, the leftover commented copy intest.yml, and the unusedGITHUB_TOKENon the webhook step.Testing: this PR's own CI run (same-repo branch) runs deploy +
cr, so it exercises the webhook update and the playground publish withoutci.ts. Tag behavior can only be checked on the next release.🤖 Generated with Claude Code