Repository navigation
fix: crash on case-only filename renames (case-insensitive filesystems) - #779 - #791
Open
theAnuragMishra wants to merge 1 commit into
Open
theAnuragMishra wants to merge 1 commit into
theAnuragMishra wants to merge 1 commit into
Conversation
On case-insensitive filesystems, renaming a file with only a case change (e.g. test.java -> Test.java) causes bufadd(dest_buf_name) to resolve to the same buffer as src_bufnr instead of creating a new one. The existing src/dest buffer-swap logic assumes two distinct buffers, so it deletes the only buffer that exists and then tries to use it again, throwing "invalid buffer id". Add a short-circuit for dest_bufnr == src_bufnr that just updates the buffer's display name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming a file via oil where only the case changes (
test.java->Test.java) throwsinvalid buffererror on a case-insensitive filesystem, but only if the file was alreadyopen in a buffer.
Cause:
vim.fn.bufadd(dest_buf_name)resolves to the same buffer assrc_bufnrwhen the two names differ only in case, since they pointto the same inode.
rename_buffer's swap logic assumessrc_bufnrand
dest_bufnrare always distinct, so it deletessrc_bufnrandthen accesses
dest_bufnr(the now-deleted same buffer) right after.Fix:
Short-circuit when
dest_bufnr == src_bufnr: just rename the bufferin place and clean up the old-name buffer.
fixes #778