Repository navigation
Conversation
The not-in filter was built from an empty id list because tagged/colored were checked for truthiness, so false never loaded the full tag/color ids and untagged/uncolored filtering returned every note. Signed-off-by: drakeo338 <paranoyouz@gmail.com>
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10443.
Description
tagged:falseandcolored:falsereturned tagged and colored notes too. The lookup only fetched the tag and color ids when the filter wastrue, sofalsewas treated as no filter at all. It now fetches them whenever the value is a boolean, the same wayin_notebookalready works. I added tests for both filters. The fixedlookup.test.jsfails on the oldlookup.tsand passes on the fix.Type of Change
Visuals
Testing
If tests were not added, explain why
Tests were added. Only
packages/core/__tests__/lookup.test.jswas run, not the full E2E or integration suites.Platform
Sign-off