Repository navigation
Fix attachment upload mobile - #10491
Open
kashaf-ansari-dev wants to merge 6 commits into
Open
kashaf-ansari-dev wants to merge 6 commits into
kashaf-ansari-dev wants to merge 6 commits into
Conversation
Signed-off-by: kashaf-ansari-dev <kashafansari3108@gmail.com>
… manual retry action Signed-off-by: kashaf-ansari-dev <kashafansari3108@gmail.com>
Signed-off-by: kashaf-ansari-dev <kashafansari3108@gmail.com>
…owing Signed-off-by: kashaf-ansari-dev <kashafansari3108@gmail.com>
…retry action Signed-off-by: kashaf-ansari-dev <kashafansari3108@gmail.com>
…deletion non-blocking Signed-off-by: kashaf-ansari-dev <kashafansari3108@gmail.com>
|
Cloudflare Pages Preview https://267bc279.notesnook-app.pages.dev Commit: b823617 |
|
Desktop Previews Commit: b823617 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses three key issues around file attachments and uploads on mobile:
mode: "open"withrequestLongTermAccess: false, and added user-facing error toasts on failure.MAX_UPLOAD_ATTEMPTS = 5) along with an exponential cooldown schedule (30s -> 2m -> 5m -> 15m) across syncs to avoid burning retries back-to-back or spamming the server. Terminal client errors (403 quota full, 413 file too large, 401 unauthorized) now fast-fail immediately.Closes #10405
Closes #10411
Closes #10389
Type of Change
Visuals
Testing
If tests were not added, explain why
Platform
Sign-off