Repository navigation
Refactor ModuleAliasTracker - #10357
Draft
bripeticca wants to merge 8 commits into
Draft
bripeticca wants to merge 8 commits into
bripeticca wants to merge 8 commits into
Conversation
* cleanup current implementation
* Proposed alias algorithm that handles name collisions * Consider closest reachable modules when resolving for applied alias names * Resolve for conflicting alias names for a module that consumes same-named modules transitively
- run proposed alias stage first, noting every affected module that would need to be aware of some dependency module's aliasing - for each set of proposed aliases, determine the criteria that makes an alias eligible to be recorded for a consuming module - add design doc explaining the motivation behind the refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10084
Update and improve the current implementation of ModuleAliasTracker for better readability, and optimizing memoized results to avoid re-computation of transitively dependent modules that resulted in an exponential increase in runtime.
WIP -- Currently fixing test failures by addressing edge cases in the refactored implementation. See ModuleAliasTracker2.
Also some heavy cleaning is still needed 😄