Repository navigation
Fix conditional traits not reaching already visited packages - #10579
Merged
plemarquand merged 1 commit intoSep 24, 2026
Conversation
plemarquand
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
rconnell9
as code owners
September 23, 2026 20:36
Contributor
Author
|
@swift-ci test |
Contributor
Author
bripeticca
approved these changes
Sep 23, 2026
Collaborator
|
@plemarquand Can you re-target to release/6.4.2, will automerge it to the rest. |
After manifests are loaded, `loadDependencyManifests` makes a pass of
`updateEnabledTraits` over all packages, in traversal order.
Consider the following package graph:
```
App ─┬─ Server ─ Proposal ─[B]─ Middle ─[L when B]─ Leaf
└─ Console ─┬─ Middle (defaults)
└─ Leaf (defaults)
```
Leaf is processed while Middle still only has its defaults. Later in
the same pass Middle gains the trait `B`, which would turn on `L` for
Leaf, but Leaf has already been processed and is never revisited, so
the graph builds Leaf without `L`.
Repeat the pass until no package's trait names change. This makes the
result independent of traversal order. It always stops, because traits
are only ever added.
plemarquand
force-pushed
the
conditional-traits-reach-already-visited-packages
branch
from
September 23, 2026 23:07
dad4efd to
2fb76e0
Compare
Contributor
Author
|
@swift-ci please test |
rconnell9
approved these changes
Sep 23, 2026
plemarquand
enabled auto-merge (squash)
September 24, 2026 10:46
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After manifests are loaded,
loadDependencyManifestsmakes a pass ofupdateEnabledTraitsover all packages, in traversal order.Consider the following package graph:
Leaf is processed while Middle still only has its defaults. Later in the same pass Middle gains the trait
B, which would turn onLfor Leaf, but Leaf has already been processed and is never revisited, so the graph builds Leaf withoutL.Repeat the pass until no package's trait names change. This makes the result independent of traversal order. It always stops, because traits are only ever added.