Repository navigation
Compose private owner admission, identity, storage and metered runner - #475
Conversation
…h-shared-issuer # Conflicts: # accounts/service/src/mod.ts # deploy/accounts-cloudflare/src/handler.ts
…h-shared-issuer # Conflicts: # docs/internal/README.md
…rage-inventory-20261015
Apply the reviewed two-path clock delta from 5131382. Excludes the unrelated catalog/schema-73 fixture. Patch SHA256: 2beb95482c295da457125481526285bbd2bca9c7e0ac94de7528e7136a4c1dd4.
Keep the ordinary nonroot runner unchanged. Isolate the root collector, kernel counter and signing custody from fixed-UID workload execution; authenticate one original attempt and require complete child-tree drain before raw CPU closure. Add versioned image/candidate/journal proofs while refusing platform activation of local-only metered proof. Include native adversarial and immutable-image qualification gates without publishing an image or enabling Cloudflare execution.
Integrate only the identity-unlink.ts and identity-unlink_test.ts delta from 5131382. Keep unrelated Control 73 catalog fixtures excluded. Scoped patch SHA-256: 2beb95482c295da457125481526285bbd2bca9c7e0ac94de7528e7136a4c1dd4.
Carry original admitted BackupRun, management witness and allocator tuple to all four backup writes. Recheck the same primary D1 evidence before custody preparation and R2 effects, preserving accepted drain settlement and pending recovery. The final D1 read and R2 effect remain non-atomic; inactive-profile legacy absence lookup retains its explicit fail-closed 4096 rows-read capacity limit.
Integrate exact 2a5db93 with ordinary history. No conflicts; original Dockerfile/start and reviewed513 clock bytes are preserved. Native image or provider qualification is outside this source-only integration.
Integrate exact1f49d7f00cd282b9c0ef2ea12b06b4f961ff2da2 using ordinary history. Preserve frozen513 identity reconciliation composition alongside original Run lease, private-file and accepted Backup safeguards; reviewed clock bytes and historical D1/PostgreSQL catalogs stay exact. No new indexes, catalog tails, runtime qualification or activation.
…TASK-0109-final-oss-owner-union
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
品質・リリース担当へ、identity/storage/metered-runner と private Accounts owner-admission の統合候補に新しい exact-head QA を依頼します。 対象 full head: umask 022; env -u NODE_ENV -u TAKOSUMI_ENVIRONMENT TAKOSUMI_E2E_PORT=43860 TAKOSUMI_DOCS_BROWSER_PORT=43861 bun run checklocal CI exit0 / 20 of20 phases PASS / 660.391s。main 6689 pass / 0 fail / 既存5 skip / 132159 assertions、isolated workerd 52 pass、harness 6 pass、browser 42 pass / 既存2 skip、docs browser 3 pass、platform/auth/bootstrap builds PASS。開始・終了 head 一致、worktree clean。full log SHA256 通常 merge の両親は frozen ab20 +2034、重複path0、最初の101 component blobsは完全保持。最後の commit は3説明文+2native fixture/testのみ。実完全v73を専用named2Worker+D1 RPCが拒否しAccounts/Control identity mutationなし、実v74成功・ledgergap・maintenance負例を保持(native46assertions)。focused80/0/1360、独立read-only review指摘なしを full CI と区別して添えています。 確認対象は complete main diff148files(identity/原Context+owner journal/availabilityと全backend local precommit checkpoint、storage/D1-only74、未有効metered runner)です。専用issuer HTTP/RPC/release厳密current74、汎用identity73/74、billing72..74、通常bridge71..74を維持し、Accounts005/PG045/Control1..73/PG120履歴は不変です。checkpointはlocaldispatch直前保証で、remote queued DB execution-time/2PC保証ではありません。 Component #473/#474 のQAをこのheadへ流用しません。実issuer/approval/Financial/Hosted-intent/RP/resource受信port/実deployedsource資格は未構成で予約前拒否、Hosted private prototype未取込です。live migration/config/key/registration/stage/prod publishは未実施。正式判断は上記完全一致SHAでお願いします。merge/rolloutは依頼していません。 |
|
head ローカル完全 gate は Bun 1.4.2 / Node 26.1.0 で 6689 pass / 0 fail でしたが、GitHub CI は workflow が指定する Bun 1.4.0 (
CI と同じ toolchain を専用作業場所に用意して原因を再現・診断中です。guard・TTL・budget・assertion を維持し、修正凍結とレビューの後に新しい head で完全 gate を実行します。既存 QA 依頼は元 head に対する pending の履歴として保持します。このコメントは新しい QA 依頼・Approve・再実行の成功報告ではありません。 |
|
品質・リリース担当へ。PR475 の新しい凍結 head
旧11d8のQA依頼やcomponent Approveは、このheadへ転用しません。full149-file source unionの fresh判定をお願いします。Hostedとの141-assertion paired proofは以前のcomponent範囲に限り、新しいcombined-headのpaired proofとは扱いません。実 owner/issuer/Financial/RP receiver と source/target/binding qualification は未構成で、profile/image/料金のactivation・staging/prod・実schema操作は行っていません。 判定は |
品質・リリース判定: ✅ Approve(head 451e69b)品質・リリース担当による exact-head レビュー結果です(#469–#474 の判定はこの head に流用していません)。 確認事項
QA 側での再現
設計との整合
Secret チェックdiff の credential 形状スキャンで該当した 12 箇所はすべて tests 配下の マージ順・フォローアップ
|
This PR composes shared identity reconciliation, private owner-operation admission, storage custody guards and the dormant metered runner into one OSS candidate. Dedicated issuer HTTP, named private RPC and release qualification share exact-current Control v74 verification; ordinary compatibility and feature-specific floors remain separate.
The complete diff against main
dac30855915e49e5a4fb9782c489a023e7ed1f5ais 149 files, +19,631 / -448, including all source, schemas, tests, workflows and documentation from the components:Provenance: ordinary merge
5118090a894f8fe0b1e4fb56b3a37d678ed454f1has exact parentsab20cbb9bf91cc7859e82de9b6e52100ab9d9a6eand2034d2aa7b33322a5e9ca4ce646be000061b07a2, with zero overlapping changed paths or merge conflicts. All 57 + 44 component blobs were initially preserved exactly. Follow-up11d8acf5cae3d624dda6656d84bdcdccdc0585b6changes only three descriptions and two native-test/fixture files: it states the actual v74 qualification and proves an intact v73 catalog is refused by the real named RPC before account/fence or Control identity mutations. Existing v74 success, ledger-gap and maintenance negatives remain; Node-hosted two-Worker/D1 runtime assertions increase from 42 to 46. All runtime guard/schema/B1/storage source blobs are unchanged from the components. The final follow-up below preserves every production/schema/authority blob from that frozen union. Component approvals are not transferred to this head.Accounts D1 history through v5 and PostgreSQL 045, Control D1 migrations 1–73 and PostgreSQL catalog 120 are byte-identical to the frozen components. D1-only migration 74 is inherited from the storage component; no new migration or PG121 is added here. The ordinary profile-disabled Accounts v4/v5 bridge remains available. No request path applies DDL.
The final CI correction
451e69bfc6743b034ee2947992bafdc41b2c6fbachanges four test-only files relative to11d8; production/runtime, schema, authority, workflow, dependencies and lockfiles are unchanged. The original HTTP workflow test file also remains byte-identical.Actual canonical GitHub run 38657030295 on
11d8failed: 6,686 pass / 3 fail / 5 skips, despite the earlier local Bun 1.4.2 / Node 26.1.0 gate passing. The failed run used workflow-pinned Bun 1.4.0 (34cbb9a40) and resolved Node 22.23.3. Its immutable failed-log SHA-256 isec4f8fb7e69e05a10d380fa146f4ac1244ea8e429049f3c948a384e1128feac9. These results are preserved separately.miniflare. Unchanged-source reproduction showed Bun 1.4.0 retained that bare external specifier even when its resolver plugin returned the installed absolute path. The fixture now supplies the installed package's file URL for Node's runtime import. The full two-Worker/D1 test passes with all 46 native assertions, the original 45s/60s limits and process disposal unchanged.Validation at
451e69bfc6743b034ee2947992bafdc41b2c6fba:bun run checkwith Bun 1.4.0 (34cbb9a40) / Node 22.23.3 / npm 10.9.9, CI/GitHub environment flags and clean source: exit 0, all 20 phases passed, 641.077s. Main portable tests: 6,690 pass / 0 fail / 5 existing opt-in skips, 132,164 assertions, 618 files. Isolated workerd: 52 pass / 458 assertions; dashboard harness: 6 pass; browser: 42 pass / 2 existing public-live opt-in skips; docs browser: 3 pass; Worker builds pass. Exact head/tree and all 1,925 tracked-file hashes match before/after, worktree clean. Full raw-log SHA-256:077805a87a82feea26c751d7526329a2bb86e5abea8ad80b3b9868c6e558f4dc. This was one complete gate on the frozen fix head.451e69bfc6743b034ee2947992bafdc41b2c6fba. Root readback confirms all 20 phases / 806.73s, 6,690 main tests / 0 failures / 132,164 assertions; all three PR checks pass. The full successful GitHub log SHA-256 is43da290c8b4cf54209bf358055da9751c0cb6a66cddf69dfec42cdda74eac390. This result is separate from the completed local pinned gate and the preserved old failed run; formal exact-head QA remains pending.The earlier ab20/Hosted5002 paired 141-assertion proof remains component evidence; a new combined-head paired proof is not claimed here. Earlier component failure/reproduction artifacts remain preserved with their original scope.
Actual review issuer/key/status transport and authenticated recovery issuance, Financial/Hosted-intent/RP/resource receiving ports, and deployed source/target/binding custody qualification remain unconfigured. Missing capabilities refuse before fencing; metadata topology reports do not establish source custody or human approval. Hosted private reconciliation prototypes are not imported. Storage remains unpriced logical occupancy. No live target/configuration/key/registration, migration/apply, image publication, stage activation or production/auth deployment was performed. This PR requests fresh exact-head QA, not merge or rollout.