Repository navigation
🐛 fix(config): fail startup on repository errors - #1861
Merged
Merged
Conversation
`build_state` discarded repository reconciliation errors, so the server could expose a configured route without its persisted identity. Propagate the storage error before `build_state` publishes application state. Nodes without write access keep skipping repository reconciliation.
Merging this PR will not alter performance
Comparing 
Footnotes
|
An oversized repository route stopped reaching the shadow query after startup began enforcing repository persistence errors. Corrupt a valid stored decision through the metadata migration boundary so both fixtures exercise the intended decode failure through the public HTTP route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writable startup could serve a configured route after repository reconciliation failed, leaving that route without the stable identity used by the management API.
Startup now propagates repository validation and storage errors before publishing application state and reports the affected routes. Nodes without write access continue to skip reconciliation, while successful restarts retain repository IDs and versions.
Closes #1396