Repository navigation
🐛 fix(webhooks): retry storage faults - #1862
Merged
Merged
Conversation
Keep the delivery worker alive when metadata operations fail and use a bounded, interruptible backoff before retrying. Retain failed delivery-status writes in memory so the worker records the exact attempt before resending an accepted request. Keep other targets moving while suppressing the affected target. Refs #1186
Merging this PR will not alter performance
Comparing 
Footnotes
|
The full-workspace report combines benchmark and test builds. The tracing macro deferred the retry delay until a subscriber enabled the event, so LLVM associated that field with the benchmark build's zero-count region. Compute the delay before dispatch. Remove the optional error branch because the sole caller has an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient metadata read stops webhook delivery and the serving process. A failed status write can also resend an accepted request before peryx records the prior attempt.
The worker now backs off metadata faults while allowing notifications and shutdown to interrupt the wait. It retains failed status writes in memory, suppresses that target until persistence succeeds, and keeps other targets moving. Process loss can still cause at-least-once redelivery with the same
X-Peryx-Deliveryvalue.Closes #1186