Skip to content

Xpetra: Epetra removal for v18 - #15972

Open
zseckert wants to merge 3 commits into
trilinos:developfrom
zseckert:epetra_removal_xpetra
Open

zseckert wants to merge 3 commits into
trilinos:developfrom
zseckert:epetra_removal_xpetra

Conversation

@zseckert

Copy link
Copy Markdown
Contributor

@trilinos/xpetra

Motivation

We are trying to clean up any remaining Epetra-stack code for the v18 release in a few weeks. The goal is to remove dead code paths that no longer build and remove documentation that discusses support that no longer exists.

Testing

I will get the PR testing passing, but this should be ready for review.

Additional Information

This was assisted by GPT-5.5. These changes are pretty straightforward. I left all the documentation, such as the readme, as is considering Xpetra's purpose as a transition package. Given Epetra's full removal in v16, do we want to consider deprecation of this package entirely or are there use cases that outlive Epetra's removal?

Assisted-by: GPT-5.4
Signed-off-by: Zakari Echo <zeckert@sandia.gov>
The headers no longer exist, so the logic is no longer needed.

Assisted-by: GPT-5.4
Signed-off-by: Zakari Echo <zeckert@sandia.gov>
Assisted-by: GPT-5.5
Signed-off-by: Zakari Echo <zeckert@sandia.gov>
@zseckert zseckert self-assigned this Nov 19, 2026
@zseckert
zseckert requested a review from a team as a code owner November 19, 2026 20:49
@github-actions

Copy link
Copy Markdown

CDash for AT2 results

Reproducing CI builds locally

CI builds can be reproduced locally in a container.

Requirements: Python 3.9+, Podman

Steps:

  • Check out the branch of the PR locally.
  • Run commonTools/pr_reproducer/reproducer.sh.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Some files in your PR did not respect the formatting rules.
Please apply the patch given below by running

commonTools/patchFromComment/getPatchFromComment.sh apply trilinos/Trilinos/pull/15972#issuecomment-7021887627

in your Trilinos source directory. Alternatively you can download a patch file here.

Patch
diff --git a/packages/xpetra/src/Utils/Xpetra_IO_def.hpp b/packages/xpetra/src/Utils/Xpetra_IO_def.hpp
index e70e5392..db038aea 100644
--- a/packages/xpetra/src/Utils/Xpetra_IO_def.hpp
+++ b/packages/xpetra/src/Utils/Xpetra_IO_def.hpp
@@ -489,7 +489,7 @@ RCP<Xpetra::MultiVector<Scalar, LocalOrdinal, GlobalOrdinal, Node>> IO<Scalar, L
     RCP<MultiVector> rmv = Xpetra::toXpetra(TMV);
     return rmv;
   } else {
-      throw Exceptions::RuntimeError("Utils::Read : you must specify Xpetra::UseTpetra.");
+    throw Exceptions::RuntimeError("Utils::Read : you must specify Xpetra::UseTpetra.");
   }
 
   TEUCHOS_UNREACHABLE_RETURN(Teuchos::null);

More details about our use of clang-format and other tools can be found in the wiki.

@mayrmt

mayrmt commented Nov 19, 2026

Copy link
Copy Markdown
Member

@cgcgcg With Epetra gone, isn't the whole concept of a map carrying an "underlying lib" and the command line option --linAlgebra obsolete? They should always be set to Tpetra now, right? If that's true, that would trigger a much more rigorous cleaning of Xpetra. Or am I missing something here?

@cgcgcg

cgcgcg commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

That's right. If we want to do things right, we need to get rid of Xpetra. This involves moving functionality from Xpetra to Tpetra or MueLu.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants