Repository navigation
Conversation
Assisted-by: GPT-5.4 Signed-off-by: Zakari Echo <zeckert@sandia.gov>
The headers no longer exist, so the logic is no longer needed. Assisted-by: GPT-5.4 Signed-off-by: Zakari Echo <zeckert@sandia.gov>
Assisted-by: GPT-5.5 Signed-off-by: Zakari Echo <zeckert@sandia.gov>
Reproducing CI builds locallyCI builds can be reproduced locally in a container. Requirements: Python 3.9+, Podman Steps:
|
|
Some files in your PR did not respect the formatting rules. commonTools/patchFromComment/getPatchFromComment.sh apply trilinos/Trilinos/pull/15972#issuecomment-7021887627in your Trilinos source directory. Alternatively you can download a patch file here. Patchdiff --git a/packages/xpetra/src/Utils/Xpetra_IO_def.hpp b/packages/xpetra/src/Utils/Xpetra_IO_def.hpp
index e70e5392..db038aea 100644
--- a/packages/xpetra/src/Utils/Xpetra_IO_def.hpp
+++ b/packages/xpetra/src/Utils/Xpetra_IO_def.hpp
@@ -489,7 +489,7 @@ RCP<Xpetra::MultiVector<Scalar, LocalOrdinal, GlobalOrdinal, Node>> IO<Scalar, L
RCP<MultiVector> rmv = Xpetra::toXpetra(TMV);
return rmv;
} else {
- throw Exceptions::RuntimeError("Utils::Read : you must specify Xpetra::UseTpetra.");
+ throw Exceptions::RuntimeError("Utils::Read : you must specify Xpetra::UseTpetra.");
}
TEUCHOS_UNREACHABLE_RETURN(Teuchos::null);More details about our use of clang-format and other tools can be found in the wiki. |
|
@cgcgcg With Epetra gone, isn't the whole concept of a map carrying an "underlying lib" and the command line option |
|
That's right. If we want to do things right, we need to get rid of Xpetra. This involves moving functionality from Xpetra to Tpetra or MueLu. |
@trilinos/xpetra
Motivation
We are trying to clean up any remaining Epetra-stack code for the v18 release in a few weeks. The goal is to remove dead code paths that no longer build and remove documentation that discusses support that no longer exists.
Testing
I will get the PR testing passing, but this should be ready for review.
Additional Information
This was assisted by GPT-5.5. These changes are pretty straightforward. I left all the documentation, such as the readme, as is considering Xpetra's purpose as a transition package. Given Epetra's full removal in v16, do we want to consider deprecation of this package entirely or are there use cases that outlive Epetra's removal?