Repository navigation
fix: harden JavaScript execution and release verification - #3
Merged
Merged
Conversation
Reuse CI for automatic releases, run native contract tests and dependency audits, smoke-test every packaged target, and fail closed before publishing. Use Tuist runners where native targets are available, retaining hosted Intel macOS and ARM Linux runners for architecture-correct execution. Amp-Thread-ID: https://ampcode.com/threads/T-01a14e21-ca93-7509-ab0d-4f71449b5a78 Co-authored-by: Pedro Piñera Buendía <pedro@pepicrft.me>
Integrate the finalized source implementation with finite execution and compilation budgets, opt-in Linux worker isolation, validated options, bounded caching, and the Rust 1.96 / Wasmtime 49 dependency updates. Ship the executable worker with precompiled NIF archives and verify both extracted artifacts. Run coverage and bound Cargo build concurrency on CI runners. Source-Thread: https://ampcode.com/threads/T-01a14e07-c4ad-72fe-a622-966760e38b13 Amp-Thread-ID: https://ampcode.com/threads/T-01a14e21-ca93-7509-ab0d-4f71449b5a78 Co-authored-by: Pedro Piñera Buendía <pedro@pepicrft.me>
pepicrft
marked this pull request as ready for review
October 18, 2026 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Integrates the finalized Rust/library implementation with the CI/release hardening in this existing PR. The implementation and workflows must land together: new advisory/formatting gates correctly reject the old main baseline, and the isolated backend requires the worker executable to be included with each NIF archive.
javex_workerwith every packaged NIF; never silently fall back to the in-process backend.Adversarial workflow fixes
Validation
mix hex.build, andmix docs --warnings-as-errorspass against the new packaged NIF. Nothing was published.Constraints
Isolation is opt-in and Linux-only, requiring close_range (kernel 5.9+) and seccomp TSYNC. Select the isolated runtime for both compile and run; standalone compile remains in-process. Host JSON/IPC allocations are outside the child's address-space limit. In-process limits do not create an OS security boundary.
Hex/Git/GitHub cannot form one transaction. If main advances after the final pre-publish check, the atomic Git push fails rather than rebasing, potentially after Hex has published. Main CI checks are nested under Release verification, so required-status names may need updating. No merge, release, or deployment has been requested or performed.