Skip to content

fix(linting-rules): increase timeout from 60 to 120 seconds - #272

Closed
GaryBrims wants to merge 1 commit into
mainfrom
fix/vacuum-pygeoapi-test-timeout
Closed

GaryBrims wants to merge 1 commit into
mainfrom
fix/vacuum-pygeoapi-test-timeout

Conversation

@GaryBrims

Copy link
Copy Markdown
Contributor

increase the linting timeout from 60 to 120 secods to allow for long API specs
Increase the jest timeout to 140 seconds

@GaryBrims
GaryBrims requested a review from a team as a code owner November 9, 2026 14:45
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

vacuum OpenAPI quality report

vacuum has graded this OpenAPI specification with a score of 100 out of a possible 100


✅ You have a perfect score! Congratulations, you're doing it right.

learn more about vacuum at quobix.com/vacuum

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Test Results

66 tests  ±0   66 ✅ ±0   43s ⏱️ -8s
11 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 8d00878. ± Comparison against base commit 736be61.

@milkshakeuk

Copy link
Copy Markdown
Member

Thanks for picking this up. I don't think we need it any more, though.

The ~80 s run was on the #268 branch before #253 landed, when it still had vacuum 0.36.2, so without the fix for daveshanley/vacuum#1045. With 0.39.3 on main and #268 rebased onto it, vacuum-pygeoapi.test.ts passed in 35 s on CI (Run Tests on bd957c7) and 17 s locally, inside the 60 s budget. #268 is now merged.

Keeping the 60 s limit also means the test still catches a slowdown like #1045 if one comes back. It's your call if you want the extra headroom anyway, but note that the diff currently converts the whole file to CRLF line endings (hence +63 −63), so it would be worth fixing that before merging.

@GaryBrims

Copy link
Copy Markdown
Contributor Author

Agreed we do not need it now.

@GaryBrims GaryBrims closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants