Skip to content

CLDR-19904 TR35 spec files for CLDR 50 proposed update - #6284

Open
btangmu wants to merge 1 commit into
unicode-org:mainfrom
btangmu:t19904_b
Open

btangmu wants to merge 1 commit into
unicode-org:mainfrom
btangmu:t19904_b

Conversation

@btangmu

@btangmu btangmu commented Nov 12, 2026

Copy link
Copy Markdown
Member

-Modify tr35-versions.yml by adding v50: r80

-Modify archive.js by removing obsolete code to "fixup captions"

CLDR-19904

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Modify tr35-versions.yml by adding v50: r80

-Modify archive.js by removing obsolete code to fixup captions
@btangmu btangmu self-assigned this Nov 12, 2026
@btangmu

btangmu commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

I removed a section of code that seemed to exist solely for handling the following two lines of tr35.md, or an earlier version of that file. It logged meaningless warnings for other <h6> elements, and also failed for these two lines:

###### Table: <a name="Part_7_Links" href="#Part_7_Links">Part 7 Links</a>: [Keyboards](tr35-keyboards.md) (keyboard mappings)
[Part 7](tr35-keyboards.md) has been extensively rewritten. The prior link anchors within this file are no longer valid.

@btangmu
btangmu deployed to spec-preview November 12, 2026 18:31 — with GitHub Actions Active
@btangmu

btangmu commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

I'm still working on "Potentially missing definitions" such as

../../../docs/ldml/tr35-messageFormat.md: Potentially missing definitions:
../../../docs/ldml/tr35-messageFormat.md: - bad-option-error

I see that *.anchors.json are auto-generated by extract-link-targets.js -- ideally they should include comments like "This file was auto-generated by extract-link-targets.js" but since they currently just contain arrays of strings, adding a comment might require changing the code that reads them as well as the code that writes them

@btangmu
btangmu requested a review from srl295 November 12, 2026 18:36
@srl295

srl295 commented Nov 12, 2026

Copy link
Copy Markdown
Member

I'm still working on "Potentially missing definitions" such as

../../../docs/ldml/tr35-messageFormat.md: Potentially missing definitions:
../../../docs/ldml/tr35-messageFormat.md: - bad-option-error

MessageFormat wanted every 'bold' or something to be a definition, but it is inconsistent. I think that should go back to the MFWG - @eemeli ?

I see that *.anchors.json are auto-generated by extract-link-targets.js -- ideally they should include comments like "This file was auto-generated by extract-link-targets.js" but since they currently just contain arrays of strings, adding a comment might require changing the code that reads them as well as the code that writes them

JSON doesn't support comments - instead, we should document it in the process page.

@btangmu

btangmu commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

MessageFormat wanted every 'bold' or something to be a definition

It's looking for "em" here:

function linkify(document, infile) {
  const terms = findTerms(document);
  const missing = new Set();
  const used = new Set();
  const links = document.querySelectorAll("em");

  links.forEach((item) => {

JSON doesn't support comments

Right, but if the file started with { instead of [ then adding a pseudo-comment would be easy like this:

{
  "_comment": "This file was auto-generated by extract-link-targets.js",
  "anchorList": [
    "accept",
    "acknowledgments",

@srl295

srl295 commented Nov 12, 2026

Copy link
Copy Markdown
Member

MessageFormat wanted every 'bold' or something to be a definition

It's looking for "em" here:

function linkify(document, infile) {
  const terms = findTerms(document);
  const missing = new Set();
  const used = new Set();
  const links = document.querySelectorAll("em");

  links.forEach((item) => {

JSON doesn't support comments

Right, but if the file started with { instead of [ then adding a pseudo-comment would be easy like this:

or "//": "this is not a comment"

that would be fine. I think more importantly than the generation would be a link to docs.

{
  "_comment": "This file was auto-generated by extract-link-targets.js",
  "anchorList": [
    "accept",
    "acknowledgments",

@srl295

srl295 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

I removed a section of code that seemed to exist solely for handling the following two lines of tr35.md, or an earlier version of that file. It logged meaningless warnings for other <h6> elements, and also failed for these two lines:

###### Table: <a name="Part_7_Links" href="#Part_7_Links">Part 7 Links</a>: [Keyboards](tr35-keyboards.md) (keyboard mappings)
[Part 7](tr35-keyboards.md) has been extensively rewritten. The prior link anchors within this file are no longer valid.

That may be a bug but it's definitely not obsolete. Deleting this section breaks the <caption> (for layout, accessibility, document metadata) that was previously applied to tables.

Before

image

This PR

image

@srl295 srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore the caption code, fix if needed

@btangmu

btangmu commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Before

image ### This PR image

I can't see a difference...

@srl295

srl295 commented Nov 12, 2026

Copy link
Copy Markdown
Member

I removed a section of code that seemed to exist solely for handling the following two lines of tr35.md, or an earlier version of that file. It logged meaningless warnings for other <h6> elements, and also failed for these two lines:

###### Table: <a name="Part_7_Links" href="#Part_7_Links">Part 7 Links</a>: [Keyboards](tr35-keyboards.md) (keyboard mappings)
[Part 7](tr35-keyboards.md) has been extensively rewritten. The prior link anchors within this file are no longer valid.
###### Table: <a name="Part_7_Links" href="#Part_7_Links">Part 7 Links</a>: [Keyboards](tr35-keyboards.md) (keyboard mappings)

[Part 7](tr35-keyboards.md) has been extensively rewritten. The prior link anchors within this file are no longer valid.

well, the issue here is that there's no table. That line should just be:

### Table: <a name="Part_7_Links" href="#Part_7_Links">Part 7 Links</a>: [Keyboards](tr35-keyboards.md) (keyboard mappings)

(h3).

h6 is supposed to be reserved for Table captions, that's what the warnings are for.

We could remove the warning or try to fix the h6's

For what it's worth, I don't think I've ever heard any feedback on these logs before.

@srl295

srl295 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

I can't see a difference...

sorry, had an issue with paste. fixed now. The caption is the tiny (h6) line.

image

Edit: if we want the caption smaller, that should be done with css on the <caption>. that's a separate concern

This branch was successfully deployed

1 active deployment
spec-preview — 56a0512f Deployed Nov 12, 2026 by btangmu via Deploy Spec to preview #486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants