[fadiroot]

What type of PR is this?

• bug

What this PR does / why we need it:

Exit() wraps the caller's error in an unexported exitError. Since #1545 (issue #1090) that wrapper had an Unwrap() method so errors.Is / errors.As could reach the original error through the ExitCoder. The method was dropped in 05071ea ("Add error tests") without being mentioned in the commit, so on v3 today:

var ErrNotFound = errors.New("not found")
err := cli.Exit(ErrNotFound, 2)
errors.Is(err, ErrNotFound) // false on main; true on v2 and on v3 before Oct 2024

origin/v2-maint still has the method.

• errors.go: add func (ee *exitError) Unwrap() error back.
• errors_test.go: TestExit_Unwrap checks errors.Is, errors.Unwrap, errors.As to ExitCoder, and the non-error message form. It fails on main and passes with this change.

No exported API changes (exitError is unexported), so godoc-current.txt is unaffected.

Release Notes

Restore `Unwrap()` on the error returned by `Exit()`, so `errors.Is` and `errors.As` see the wrapped error again.

[Juneezee]

I think something went wrong with your rebase and force-push. Please check your commits and changes

[fadiroot]

Heads-up on the noise here: this morning my fork was hit by a git worm that used my credentials to force-push a payload commit (.vscode/tasks.json + public/fonts/* + an obfuscated blob in a config file) over the head of every branch, including this PR's. I've restored the branch to the original commit, so the PR is back to only the intended files. Nothing else changed; sorry for the confusion, and please double-check the diff before merging.

[fadiroot]

@Juneezee you were right, but it wasn't a rebase: a git worm used my credentials this morning to force-push a payload commit over every branch in my fork (.vscode/tasks.json, public/fonts/*). The branch is restored to the original commit, so the PR is again only the two intended files (errors.go + errors_test.go), CI is green. Could you take another look? Sorry for the noise.