Skip to content

fix: propagate validator errors from empty bool sources #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juneezee merged 3 commits into from
Oct 7, 2026
Merged

fix: propagate validator errors from empty bool sources #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b60e7cb
fix: propagate validator errors from empty bool sources
sergioperezcheco Oct 3, 2026
9f82248
test: list bool source validator variants explicitly
sergioperezcheco Oct 3, 2026
271990f
test: cover empty bool source validation in TestFlagsFromEmptyEnv
Juneezee Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions flag_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,14 @@ func (f *FlagBase[T, C, V]) PostParse() error {
continue
}

if val != "" || kind == reflect.String {
if err := f.Set(f.Name, val); err != nil {
return fmt.Errorf(
"could not parse %[1]q as %[2]T value from %[3]s for flag %[4]s: %[5]s",
val, f.Value, source, f.Name, err,
)
}
} else {
_ = f.Set(f.Name, "false")
if val == "" && kind == reflect.Bool {
val = "false"
}
if err := f.Set(f.Name, val); err != nil {
return fmt.Errorf(
"could not parse %[1]q as %[2]T value from %[3]s for flag %[4]s: %[5]s",
val, f.Value, source, f.Name, err,
)
}

f.hasBeenSet = true
Expand Down
11 changes: 11 additions & 0 deletions flag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,17 @@ func TestFlagsFromEmptyEnv(t *testing.T) {
wantValue: false,
wantIsSet: true,
},
{
name: "an empty bool still runs the validator",
env: map[string]string{"DEBUG": ""},
fl: &BoolFlag{Name: "debug", Value: true, Sources: EnvVars("DEBUG"), Validator: func(b bool) error {
if !b {
return errors.New("debug must be true")
}
return nil
}},
errContains: "debug must be true",
},
}

for _, tc := range testCases {
Expand Down
Loading