Repository navigation
Changes after user feedback - #3
Merged
Merged
Conversation
Before installing Nagini, warn (modal) if the selected interpreter is a global/system Python rather than a virtual environment, offering to select one instead. When pip fails because the environment is externally managed (PEP 668), show a clear message pointing at a virtual environment instead of the raw exit code. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pip falls back to a --user install when the interpreter's site-packages is not writeable, placing the nagini/nagini_client scripts in the per-user scripts directory rather than the interpreter's default one. Query both directories and use whichever actually contains the executable, so a successful --user install is no longer reported as "not installed". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
When the server fails to start because its port is already in use (e.g. a stale server is still running), detect the address-in-use error and offer to disable server mode so verification can still run with a per-file process. Route all server-start failures through one handler and stop the server's close handler from also popping up a duplicate error for failures that a caller already reports. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
"Local" implied local-vs-remote; "Direct" better conveys running Nagini directly (one process per verification) as opposed to via the persistent server. Updates the status-bar label, tooltip, a log message, and the README. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace the generic $(unverified) codicon on the editor title-bar action with the Nagini logo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some issues after user feedback:
Some cosmetic changes: