You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR includes the external options and definePwaConfig to allow externalize the pwa configuration: included both, config/types and config subpackages exports.
This PR also includes small changes at core types: we should remove Vite or change some jsdocs.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: ef9fd089-0552-42a8-aa14-db5674cd84c4
📥 Commits
Reviewing files that changed from the base of the PR and between d404f04 and d258c13.
📒 Files selected for processing: 6
packages/core/src/types.ts
packages/vite/package.json
packages/vite/src/node/config/index.ts
packages/vite/src/node/config/types.ts
packages/vite/src/node/vite-context.ts
packages/vite/tsdown.config.mts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The Vite package adds a typed configuration helper and public exports for its configuration module and types. The changes also update the base option description and context type import path, and add post-build JavaScript type cleanup.
Changes: Vite configuration
Layer / File(s)
Summary
Config helper and public types packages/core/src/types.ts, packages/vite/src/node/config/*, packages/vite/package.json, packages/vite/src/node/vite-context.ts
Adds definePwaConfig and the ExternalPWAOptions type, exposes config entry points, and updates the base description and context type import path.
Build configuration and cleanup packages/vite/tsdown.config.mts
Derives cwd from the config URL, removes webpack and rspack from deps.neverBundle, and runs cleanupJSTypes(cwd) after the build.
The PR adds a typed configuration helper and public exports. The build configuration is consistent with those exports, and the bundler-exclusion change does not affect the inspected package graph; no concrete merge-blocking risk remains.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 5 files. (1 skipped: 1 …
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title is concise, follows the conventional commit format, and clearly identifies the addition of the Vite configuration helper.
Description check
The description explains the addition of external options and definePwaConfig, identifies the affected exports, references a linked issue, and provides additional context about the core type changes.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 5 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg: coreChanges affecting the core packagepkg: viteChanges affecting the vite build package
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the external options and definePwaConfig to allow externalize the pwa configuration: included both, config/types and config subpackages exports.
This PR also includes small changes at core types: we should remove Vite or change some jsdocs.
Linked Issues
Refs #5
Additional Context
Summary by CodeRabbit
definePwaConfigto provide typed configuration for Vite PWA settings.