Skip to content

chore(ci): fix prepack scripts - #39

Merged
userquin merged 1 commit into
mainfrom
userquin/fix-pnpm-pack-and-prepack
Oct 25, 2026
Merged

userquin merged 1 commit into
mainfrom
userquin/fix-pnpm-pack-and-prepack

Conversation

@userquin

@userquin userquin commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Description

This PR removes ignoreScripts: true from pnpm workspace (we also have allowBuilds): ignoreScripts: true breaks the release workflow when running pack, prepack script won't run (that runs the tsdown build) and so package tgz files empty.

Linked Issues

Additional Context

Summary by CodeRabbit

  • Chores
    • Install-time scripts are no longer globally ignored by the workspace configuration, so eligible scripts can run during package installation.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a3b1012a-3feb-4068-a6a5-85c08bfc64c8
Commits

Reviewing files that changed from the base of the PR and between 777cc71 and 799e999.

Files selected for processing: 1
  • pnpm-workspace.yaml
Files with no reviewable changes: 1
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The workspace configuration no longer sets ignoreScripts: true.

Changes: Workspace Configuration

Layer / File(s) Summary
Remove the script setting
pnpm-workspace.yaml
The workspace configuration no longer sets ignoreScripts: true.

Priority: High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to 799e9

The configuration now permits the package builds to run during release packing. No merge-blocking issue was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the CI-related fix to the prepack scripts and accurately reflects the main change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description explains the change and identifies the release workflow problem caused by ignoreScripts: true. The Linked Issues and Additional Context sections are empty, but no linked issue or extra…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Description check

Explanation

The description explains the change and identifies the release workflow problem caused by ignoreScripts: true. The Linked Issues and Additional Context sections are empty, but no linked issue or extra reviewer focus is required to understand the change.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@userquin userquin changed the title chore(ci): fix prepack script chore(ci): fix prepack scripts Oct 25, 2026
@pkg-pr-new

pkg-pr-new Bot commented Oct 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@unplugin-pwa/core@39
pnpm add https://pkg.pr.new/@unplugin-pwa/inspector@39
pnpm add https://pkg.pr.new/@unplugin-pwa/types@39
pnpm add https://pkg.pr.new/@unplugin-pwa/vite@39

commit: 799e999

@userquin
userquin merged commit 730f1c4 into main Oct 25, 2026
13 checks passed
@userquin
userquin deleted the userquin/fix-pnpm-pack-and-prepack branch October 25, 2026 11:18
@github-actions github-actions Bot mentioned this pull request Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant