Repository navigation
fix(VFileUpload): apply width props only to the input - #23327
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23324
VFileUpload passes its props to both VInput and VFileUploadDropzone. Both accept width, minWidth and maxWidth (VInput picks them from the dimension props, the dropzone gets them through VSheet), so the size was applied twice: with width="80%" the input was 80% of its container and the dropzone was 80% of that. Pixel values looked fine because applying them twice gives the same result.
The dimension props now only go to VInput, and the dropzone fills it.
Added a browser spec that checks the input and the dropzone widths for width / max-width with percentage and pixel values, and with inset-file-list. The percentage cases fail without the change.