Repository navigation
Retry the stern download in capture-logs on transient errors - #18
Merged
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the stern download resilience update.
No open issues 🎉
What changed in this PR
Improves resilience of the stern download used by the capture-logs action, reducing failures caused by transient network or release-host errors.
Changes:
- Makes curl fail on HTTP errors and retry failed downloads up to three times.
- Adds connection and low-speed timeouts so stalled downloads can be retried.
- Suppresses progress output while preserving error messages.
| File | Description |
|---|---|
.github/actions/capture-logs/action.yml |
Adds error handling, retries, and timeout controls to the stern download. |
Review effort: Balanced
jfrancoa
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stern install step ran
curl -Lwith no-fand no retry, so a one-off error page from the GitHub release host was saved as the tarball andtarfailed with "gzip: stdin: not in gzip format". A weaviate-e2e-tests downgrade job died that way after its cluster had deployed and before any test ran.With
-f, curl fails on an HTTP error and names the status, and--retry-all-errorsretries that as well as a connection dropped mid-transfer.--speed-limit 1024 --speed-time 30aborts an attempt that sends under 1 KiB/s for 30 seconds, so a stalled connection is retried rather than holding the job until its timeout.