Skip to content

Retry the stern download in capture-logs on transient errors - #18

Merged
jfrancoa merged 1 commit into
mainfrom
retry_stern
Nov 3, 2026
Merged

jfrancoa merged 1 commit into
mainfrom
retry_stern

Conversation

@dirkkul

@dirkkul dirkkul commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

The stern install step ran curl -L with no -f and no retry, so a one-off error page from the GitHub release host was saved as the tarball and tar failed with "gzip: stdin: not in gzip format". A weaviate-e2e-tests downgrade job died that way after its cluster had deployed and before any test ran.

With -f, curl fails on an HTTP error and names the status, and --retry-all-errors retries that as well as a connection dropped mid-transfer. --speed-limit 1024 --speed-time 30 aborts an attempt that sends under 1 KiB/s for 30 seconds, so a stalled connection is retried rather than holding the job until its timeout.

Copilot AI balanced review requested due to automatic review settings November 3, 2026 12:42

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the stern download resilience update.

No open issues 🎉

What changed in this PR

Improves resilience of the stern download used by the capture-logs action, reducing failures caused by transient network or release-host errors.

Changes:

  • Makes curl fail on HTTP errors and retry failed downloads up to three times.
  • Adds connection and low-speed timeouts so stalled downloads can be retried.
  • Suppresses progress output while preserving error messages.
File Description
.github/​actions/​capture-logs/​action.yml Adds error handling, retries, and timeout controls to the stern download.

Review effort: Balanced

@jfrancoa
jfrancoa merged commit 3366640 into main Nov 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants