Skip to content

docs: correct wrong counts and stale pointers - #1872

Merged
y3owk1n merged 1 commit into
mainfrom
docs/fix-counts-and-pointers
Oct 25, 2026
Merged

y3owk1n merged 1 commit into
mainfrom
docs/fix-counts-and-pointers

Conversation

@y3owk1n

@y3owk1n y3owk1n commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Description

This PR corrects wrong numbers and stale pointers in the docs. Two ADRs gave counts whose parts did not add up to their totals, and a third called a list complete after two of its entries had been deleted, which now carries an amendment note. The glossary claimed alphabetical order with two entries swapped. Three contributor and user skills pointed at a file that does not exist, at a platform matrix the README no longer has, and described Windows per-app matching as matching the executable name when it matches the full executable path, which the README now also says.

Related Issues

None.

Target Platform

  • Platform-agnostic (shared logic, no OS-specific code)
  • macOS
  • Linux
  • Windows

Type of Change

  • feat: New feature
  • fix: Bug fix
  • refactor: Code restructuring (no behavior change)
  • perf: Performance improvement
  • docs: Documentation only
  • test: Adding or updating tests
  • chore: Build, CI, dependencies, tooling

Cross-Platform Checklist

  • OS-specific files use correct build tags (e.g., //go:build darwin)
  • No darwin imports from untagged (shared) code, per The One Rule
  • Stub implementations added for other platforms (returning CodeNotSupported)
  • N/A: This PR does not touch platform-specific code

General Checklist

  • Code formatted (just fmt)
  • just ci passes. N/A: docs only, so the docs fast path just fmt-check && just lint plus the architecture guardrails (doc links, anchors, citations) was run instead
  • Tests added/updated for new or changed functionality. N/A: docs only
  • Documentation updated (if applicable)
  • PR title is a conventional commit
    subject written for users. This PR squash-merges, so the title is what
    Release Please ships in the changelog, not the commits on the branch

Additional Context

ADR 0006 said 350 leaf paths split 188 written and 165 absent. The
absences are itemised to 165 and a recount of the schema at 114c86e
reproduces 350, so the written count is 185.

ADR 0011 gave 166 normative statements, but its three exhaustive groups
of 26, 79 and 37 sum to 142, and nothing else cites 166.

ADR 0007 still called its seven pinned copies the complete set after
#1691 deleted the two autohide pins. An amendment now says five remain.

The glossary claimed alphabetical order with Focused app before Event.
The add-config-option skill named a nonexistent ARCHITECTURE file, the
file-issue skill sent readers to a README matrix that does not exist,
and the setup-config skill said Windows matches an executable name.
Windows matches the full executable path, as the README and the
configuration reference already said.
@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This documentation-only PR appears safe to merge.

Summary

This documentation-only PR fixes counts, stale pointers, and Windows app-matching guidance.

  • Windows app matching uses the full executable path.
  • Contributor guides point readers to the current reference pages.
  • The design records show corrected totals and a dated pinned-copy list.
  • Focused app now sits after Event in the glossary.

Acknowledged by y3owk1n: ADR 0007 retains the “as of #1407” wording even though the seventh pin landed in #1410. The PR description explicitly says this was left as written.

Reviews (1) · Last reviewed commit: "docs: correct wrong counts and stale poi..." · Reviewed by Greptile

@y3owk1n
y3owk1n merged commit 046944f into main Oct 25, 2026
27 checks passed
@y3owk1n
y3owk1n deleted the docs/fix-counts-and-pointers branch October 25, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant