Repository navigation
Create extensions in name order and retry the ones that need another - #3216
Open
khushi-git-7 wants to merge 1 commit into
Open
khushi-git-7 wants to merge 1 commit into
khushi-git-7 wants to merge 1 commit into
Conversation
syncExtensions created new extensions in Go map order, which is random. An extension that needs another one of the list (postgis_topology needs postgis) then failed and waited for the next sync. Create them in name order, and try the failed ones again in the same sync while a pass creates at least one more. An extension that cannot be created still stops the loop and is reported as before. Fixes zalando#2198 Signed-off-by: Khushi Jain <jainkhushibts@gmail.com>
khushi-git-7
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi and
mikkeloscar
as code owners
November 3, 2026 18:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2198
syncExtensionscreated the new extensions in Go map order, which changes from run to run. An extension that needs another one of the list (postgis_topologyneedspostgis,hstore_plperlneedsplperl) then failed withrequired extension ... is not installed, and since #2262 it only got created on a later sync.Now
createExtensionsInOrder:The SQL, the alter path and the error collection from #2262 stay as they are.
Tests
TestCreateExtensionsInOrderuses a create function that fails until the extensions it needs exist.hstore_plperlcomes beforeplperlin name order, so one pass is not enough. It also checks that an extension that is not available is reported once and the others are still created.required extension "plperl" is not installed(run).gofmt -lis clean,go vet ./pkg/cluster/passes, and the new test passed 20 runs with-race.