Repository navigation
fix(model): support large whisper models and default to large-v3-turbo - #6
Merged
Merged
Conversation
whisper.cpp's --dtw presets for large models are dotted (large.v3, large.v3.turbo) but the model filenames are hyphenated, so _model_short_name produced invalid presets like 'large-v3' and whisper-cli rejected them. Convert large-* names to dotted form. Also switch the default model from medium.en to large-v3-turbo and update MODEL_SIZES, download help, tests, and docs to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes large whisper models being unusable and makes
large-v3-turbothe default._model_short_name()feeds the model name towhisper-cli --dtw. whisper.cpp's DTW presets for large models are dotted (large.v3,large.v3.turbo), but the model filenames are hyphenated (ggml-large-v3-turbo.bin). The old code stripped theggml-prefix and passed the hyphenated name through, so--dtw large-v3was rejected and any large model failed. The fix convertslarge-*names to dotted form.It also switches the default model from
medium.entolarge-v3-turboand updatesMODEL_SIZES, the download help text, tests, and docs to match.Changes:
MODEL_SIZES, help text, docstringlarge-v3andlarge-v3-turbomappingruff and pytest pass locally.