Repository navigation
fix: join whisper subword tokens using leading-space word boundaries - #9
Merged
Merged
Conversation
parse_wts stripped the leading space that whisper.cpp puts before word-initial tokens, so subword tokens became separate words ("Cloud fl are", "Wr angle r") unless listed in COMPOUND_MERGES. Use that space to decide word boundaries, including words split across whisper segments. COMPOUND_MERGES stays as a fallback for words whisper heard as two words.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes split words in captions like "Cloud fl are" and "Wr angle r".
whisper.cpp marks the start of each word with a literal space before the token in the
.wtsoutput.parse_wts()stripped that space, so every subword token became its own word unless someone had added it toCOMPOUND_MERGES. That list kept growing and never covered everything, including words split across two whisper segments (replace Wr/angler.).parse_wts()now joins tokens without a leading space onto the previous word. This also covers contractions and trailing punctuation, so the separate punctuation and contraction regexes are gone.COMPOUND_MERGESstays as a fallback for words whisper actually heard as two words (Cloud flare).I checked this against 25 clips from a recent video and got no split words. Tests cover the subword, cross-segment, and fallback cases. The README and AGENTS.md are updated.