Repository navigation
fix(alerts): treat empty stored right-hand fields as missing - #3
Merged
Merged
Conversation
Kite returns empty strings rather than nulls for unset right-hand
fields, and the crate reads them as Some(""). alerts modify passed
those through, so a stored instrument condition with an empty
exchange, symbol or attribute sent the empty value instead of using
the default or failing with the existing error.
Follow-up to #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1. Kite returns empty strings rather than nulls for unset right-hand fields, and the crate reads them as
Some("").alerts modifypassed those through when reusing the stored alert:--rhson a stored instrument alert with an emptyrhs_attributesent""instead of defaulting toLastTradedPrice.--rhssent an empty exchange, symbol or attribute instead of failing with the existing "stored alert has no right-hand ..." error.A small
stored()helper now treats an empty stored value as missing at all four reads.Evidence
alerts_modify_treats_an_empty_stored_rhs_attribute_as_missingintests/cli_output.rsuses an instrument alert withrhs_attribute: "". It fails before the change (exit 0 with the empty value sent) and passes after.cargo fmt --check,cargo clippy -D warningsand the alert tests pass locally.