Repository navigation
feat: add setupJob.enabled to gate the setup Job - #632
Open
bstanforth-mitek wants to merge 1 commit into
Open
bstanforth-mitek wants to merge 1 commit into
bstanforth-mitek wants to merge 1 commit into
Conversation
Mirror initJob.enabled so multi-region deployments that share one Postgres can disable setup (migrations + FirstInstance) on secondary clusters. FirstInstance.Skip alone does not omit the Job or skip migrations.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
setupJob.enabled(defaulttrue) mirroringinitJob.enabled, so operators can omit the setup Job on secondary clusters that share one Postgres with a primary that already runs migrations / FirstInstance.zitadel.configmapConfig.FirstInstance.Skiponly skips FirstInstance provisioning inside setup; it does not skip migrations or remove the Job. Concurrent setup Jobs against a shared DB can race non-idempotent DDL (e.g.07_logstore/protocol_date_desc already exists).Changes
templates/job_setup.yamlwith{{- if .Values.setupJob.enabled }}setupJob.enabledinvalues.yamlandvalues.schema.jsonTest plan
helm templatewithsetupJob.enabled: truestill emits the setup Jobhelm templatewithsetupJob.enabled: falseemits no*-setupJobinitJob/ Deployment / login templates unchanged