Repository navigation
Avoid owner and group lookups in WASI filestat - #266
Merged
andreaTP merged 1 commit intoNov 2, 2026
Merged
Conversation
fd_filestat_get, path_filestat_get and fd_readdir read "unix:*", which also resolves the owner and group names. None of them use those, so request only the attributes that writeFileStat and getFileType read.
andreaTP
reviewed
Oct 31, 2026
andreaTP
left a comment
andreaTP
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your interest in the project!
I'll have a look early next week.
Contributor
|
Thanks, @fahrradflucht nice find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fd_filestat_get,path_filestat_getandfd_readdirreadunix:*, which also resolves the owner and group names (getpwuid/getgrgid) on every call. None of them use those, so this only asks for the attributeswriteFileStatandgetFileTyperead.I hit this running SQLite on Endive, which stats the database file on every read transaction. Single-threaded point reads went from 168k to 198k/s on macOS, and on its own
Files.readAttributesgoes from 76k to 659k calls/s on Linux.